test: update github actions CI and run tests on LTS and pre#1002
test: update github actions CI and run tests on LTS and pre#1002franckgaga wants to merge 2 commits intoJuliaControl:masterfrom
LTS and pre#1002Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 41 41
Lines 5096 5096
=======================================
Hits 4715 4715
Misses 381 381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@baggepinnen See above, I think it's a great improvement to be a bit less "extinguishing the fire" in the maintenance of the package XP It seems the the failling tests on |
|
So I'm pretty sure that it's a bug in Julia 1.12, not in this package. |
|
The testing on |
| actions: write | ||
| contents: read | ||
| continue-on-error: ${{ matrix.version == 'pre' }} # the CI badge will still pass if 'pre' fails | ||
| continue-on-error: ${{ matrix.version == 'pre' || matrix.version == 'nightly' }} # the CI badge will still pass if 'pre' or 'nightly' fails |
There was a problem hiding this comment.
That is why I added this line. The failure on pre will be ignored in the final CI results.
There was a problem hiding this comment.
Note that the icons below can be misleading since there is a big red X on pre. The CI badges will still be green howeve, as far as I know.
This is an issue with GitHub actions, the allow-failure setting does not exist for now actions/runner#2347
Trying to:
test.ymlwith new github actions #975 (it theoretically improves the performance of testing on CI with caching of testing dependencies)pre: it can be useful for preemptive testing and is less noisy thannightly)Since
preis not intended for normal julia users (i.e. non-package developers), I don't think it should impact the CI badge.