WIP: handle zero_tangent from cyclic data structures v2 Via premapping#655
Open
WIP: handle zero_tangent from cyclic data structures v2 Via premapping#655
Conversation
f9ade6e to
95e63d0
Compare
f4621e7 to
ddd1647
Compare
Member
Author
|
no this plan won't work right as as. I think we are going to need to topo sort this or something. |
Member
Author
|
ok, so cycles are only possible with mutation.
|
ddd1647 to
9df22e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #654
I think it is more promising and should minimize the type instability outside of cyclic locations
Basically here is the idea:
undefelements, so set the tangent value as alsoundefor to aZeroTangentThis will also handle aliases outside of loops correctly.