Open
Conversation
willtebbutt
reviewed
Feb 3, 2020
Co-Authored-By: willtebbutt <wt0881@my.bristol.ac.uk>
Member
|
@oxinabox what's the status of this PR? |
Member
Author
|
Current status is the test failures need debugging and fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out type-stability was causing a bunch of allocations.
Type inference was failing for some reason.
Also tracking history surpisingly, causes allocations.
We don't need to track history when doing grad anyway.
This is built ontop of #59 and that should be merged first.
This PR decreases allocation count by >60%
and decreases allocation amoun t by >30%.
But that does not translate directly into speed.
I guess it won't pay off much til the garbage collector gets avoided...
Current (oxmut1)
New with Stability improvements