Open
Conversation
…tions as a dependency
Krastanov
requested changes
Feb 19, 2026
Member
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
Thanks for looking into that, the help is really appreciated! I left a few requests for changes.
Member
There was a problem hiding this comment.
Do we need this file? I would prefer to stick to the default unless there are specific reasons to avoid it.
Comment on lines
+8
to
+9
| Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
| DocumenterCitations = "daee34ce-89f3-4625-b898-19384cb65244" |
Member
There was a problem hiding this comment.
these should not be dependencies of the project as a whole, only of the docs
Comment on lines
+28
to
+31
| ## References | ||
|
|
||
| ```@bibliography | ||
| ``` |
Member
There was a problem hiding this comment.
This should probably be a more central page, as it will contain all references ever added, not just the references about centrality. I would suggest making a new page dedicated just to references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I have used DocumenterCitations for citing sources of different algorithms used in Graphs.jl package. Currently, I have made changes only to
centralityalgorithm API. Once these changes look good, I will incorporate the changes to other files as well.