Fix bug where closing quote was not removed#468
Open
tec wants to merge 1 commit intoKeyang:masterfrom
Open
Conversation
from parsed cell when there are delimiters inside the quoted text and trailing whitespace before the next cell delimiter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seen many (manually edited) csv files in the wild that are formatted to visually have commas like columns. Example:
The current implementation has some errors with those lines.
This closing quote and the whitespace is not removed (only the last space to be precise):
This whitespace is not removed even if option trim is enabled (neither is the closing quote)
The pull requests fixes those issues