Skip to content

Out of place sentence replacement #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpsimon09 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Out of place sentence replacement #295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c01d65
Removed out of context sentence and improved a clarity of device crea…
wpsimon09 Jan 29, 2026
5960239
Merge pull request #1 from wpsimon09/wpsimon09-setup-small-improvement
wpsimon09 Jan 29, 2026
3b906a7
Fix typos and enhance logical device creation details
wpsimon09 Jan 29, 2026
4aba80a
Added ,
wpsimon09 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,17 +165,17 @@ link:https://docs.vulkan.org/spec/latest/chapters/raytracing.html#extendingvulka
That means that the `enabledLayerCount` and `ppEnabledLayerNames` fields of
`VkDeviceCreateInfo` are ignored by up-to-date implementations.

As mentioned earlier, we need several device-specific extensions for our application to work properly.
With the `vk::DeviceCreateInfo` filled in, we can now proceed with creating logical device.

[,c++]
----
device = vk::raii::Device( physicalDevice, deviceCreateInfo );
----

The parameters are the physical device to interface with, and the usage
info we just specified, the optional allocation callbacks pointer and a pointer
to a variable to store the logical device handle in. Similarly to the instance
creation function, this call can throw errors based on enabling non-existent
Passed parameters are the physical device to interface with, and the create
info we`ve just specified. Additional and optional parameters include the allocation callbacks pointer and a pointer
specifying where to store the created logical device handle. In our case, the function call returns the `vk::Device` handle directly.
Similarly to the instance creation function, this call can throw errors based on enabling non-existent
extensions or specifying the desired usage of unsupported features.

Logical devices don't interact directly with instances, which is why it's not
Expand Down
Loading