fix: Add stdc++fs to link path to compatible with gcc#88
fix: Add stdc++fs to link path to compatible with gcc#88winest wants to merge 1 commit intoKoihik:masterfrom
Conversation
|
It's not necessary for our use case. |
|
hmm..that's interesting. I thought it works because I use gcc 8.3(latest on official Ubuntu 1804) with this fix to format 10,000+ files correctly. Anyway, thanks for your check and good code. |
|
@winest you could run the test suite. |
|
@tammela
My environment:
|
|
Confirmed that apparently they fixed this issue (segfault on fs lib) in 8.3. I did a PR that addressed the code issues here and made it work in all platforms. Thank you! |
fix: link to stdc++fs when needed as discussed in #88
gcc need to specify libstdc++fs to support when specifying CMAKE_CXX_STANDARD=17
Refer to https://gitlab.kitware.com/cmake/cmake/issues/17834