Array of objects json export reviwed#579
Open
JuanBerrocal wants to merge 6 commits intoLemoncode:vnextfrom
Open
Array of objects json export reviwed#579JuanBerrocal wants to merge 6 commits intoLemoncode:vnextfrom
JuanBerrocal wants to merge 6 commits intoLemoncode:vnextfrom
Conversation
…t-property test again
…cument-property test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into this issue. The problem was that the array of objects are never processed.
In the file: src\pods\toolbar\components\export-button\export-button.business.ts
This function: getPropertyJsonSchema suposses that every array is made up of base type items.
When an array is found, always made this:
return
"${field.name}": { bsonType: "array", items: ${field.type} };So if an object is the item of an array, always returns:
return
"${field.name}": { bsonType: "array", items: "object" };But doesnt return any property from the object.
To resolve this I've used a new function, getItemType.
This function process every item from the array and make a recursive call on getPropertiesJsonSchema if necessary.
So nested objects are also treated.