Skip to content

Conversation

@marmichalski
Copy link
Contributor

No description provided.

@ksaveras
Copy link

My first personal impression is that we should use a separate repository for storage type mappings. Lendable doctrine types would focus on single purpose and we could focus here on date without storage dependencies.

Feel free to ignore my comment or share your ideas.

Copy link
Member

@martin-georgiev martin-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend the tests to validate against postgresql too, please?

@martin-georgiev
Copy link
Member

@marmichalski gentle nudge

@marmichalski
Copy link
Contributor Author

My first personal impression is that we should use a separate repository for storage type mappings. Lendable doctrine types would focus on single purpose and we could focus here on date without storage dependencies.

Would likely make sense to have a types repository for each project, eg clock-dbal providing those.

Can you extend the tests to validate against postgresql too, please?

Testing multiple platforms for this Type does not really matter as the cocnrete platform is not used for anything much, plus those are just unit tests, platform could just as well be a test double.

@marmichalski gentle nudge

I will close this for now as I am not sure clock repo should be providing all possible bridges on it's own, thus this was in draft since forever.

@marmichalski marmichalski deleted the dbal-date-type branch January 24, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants