Skip to content

fix: only logging when level permits it on Windows #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Piloalucard wants to merge 2 commits into
base: v2.4.8-windows-support
Choose a base branch
from
Open

fix: only logging when level permits it on Windows #569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba1e57
fix: only logging when level permits it
Piloalucard Feb 6, 2026
ec84a50
Added condition for help messages
Piloalucard Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/libltfs/ltfslogging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,14 @@ int ltfsmsg_internal(bool print_id, int level, char **msg_out, const char *_id,
}

#ifdef mingw_PLATFORM
va_start(argp, _id);
vsyslog2(level, output_buf, argp);
va_end(argp);
if (level <= ltfs_syslog_level
|| level <= ltfs_log_level
|| level == (LTFS_TRACE + 1)) // For "Help" messages
{
va_start(argp, _id);
vsyslog2(level, output_buf, argp);
va_end(argp);
}
#else
va_start(argp, _id);
vfprintf(stderr, output_buf, argp);
Expand Down
Loading