-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add step to workflow to publish docker image to docker registry #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ananyaa06
wants to merge
22
commits into
main
Choose a base branch
from
DockerWorkflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b8ad1e4
feat(admin): add new edit site page with server API integration
ananyaa06 feae45b
fix: update the schema file so that calls can be made properly to the…
ananyaa06 90758fe
fix: correct the name of the new page wherever relevant
ananyaa06 2deaff3
feat: create functions for editing and creating Site model via API calls
ananyaa06 4d7c997
feat(admin): add site creation and editing page with MongoDB integration
ananyaa06 e9559b4
fix: change the CreateEditSite and ListSites pages to use the correct…
ananyaa06 eb85da0
fix: remove old attempt at passing in props
ananyaa06 ec7cebc
feat: use URL to load site information when editing
ananyaa06 2d6aa54
feat: connect API calls to save button in CreateEditSite
ananyaa06 9a19eab
refactor: import for color picker
ananyaa06 915ae95
fix: change how sites are parsed from JSON to fix boundary loading
ananyaa06 071aea1
refactor: run npm format
ananyaa06 80ba976
feat: add additional validation to all lat/long data entry in CreateE…
ananyaa06 5a44971
refactor: replace old edit-site routing with new UI
ananyaa06 04bb588
refactor: replace api/sites with api/public-sites
ananyaa06 fdce863
Revert "refactor: replace api/sites with api/public-sites"
ananyaa06 afa04c0
refactor: replace api/public-sites with api/sites and make necessary …
ananyaa06 9305d53
feat: add confirmation dialog to site deletion plus edit handleSave s…
ananyaa06 a4e9f7d
refactor: run npm format
ananyaa06 c47f476
refactor: remove old-sites
ananyaa06 f78de4a
fix: put edit-sites behind secure
ananyaa06 b50fe85
feat: add step to workflow to publish docker image to docker registry
ananyaa06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,16 @@ build-%: validate-semver-% | |
| @echo "Create docker container for $(VIS_DOCKER_IMAGE_NAME) with version $*" | ||
| docker build -t $(VIS_DOCKER_IMAGE_NAME):$* -f vis.dockerfile . | ||
|
|
||
| # Publish to Docker registry (e.g., make publish VERSION=1.2.3) | ||
| .PHONY: publish | ||
| publish: validate-semver-$(VERSION) | ||
| @echo "Building and publishing $(VIS_DOCKER_IMAGE_NAME):$(VERSION)" | ||
| docker build -t $(VIS_DOCKER_IMAGE_NAME):$(VERSION) -f vis.dockerfile . | ||
| docker tag $(VIS_DOCKER_IMAGE_NAME):$(VERSION) icr.infra.seattlecommunitynetwork.org/$(VIS_DOCKER_IMAGE_NAME):$(VERSION) | ||
| docker tag $(VIS_DOCKER_IMAGE_NAME):$(VERSION) icr.infra.seattlecommunitynetwork.org/$(VIS_DOCKER_IMAGE_NAME):latest | ||
| docker push icr.infra.seattlecommunitynetwork.org/$(VIS_DOCKER_IMAGE_NAME):$(VERSION) | ||
| docker push icr.infra.seattlecommunitynetwork.org/$(VIS_DOCKER_IMAGE_NAME):latest | ||
| @echo "Successfully published $(VIS_DOCKER_IMAGE_NAME):$(VERSION) to registry" | ||
|
|
||
| # The target for development | ||
| .PHONY: dev | ||
|
|
@@ -45,4 +55,5 @@ dev: | |
| -v $(CURRENT_DIR):/app \ | ||
| -w /app \ | ||
| -p $(EXPOSED_PORT):$(EXPOSED_PORT) \ | ||
| --network ccn-coverage-api_coverage-app-network \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I dont think you should add this? |
||
| $(DOCKER_IMAGE) /bin/bash | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you update the wording to
New version?