Fix/docs and cleanup #217
Merged
Fix/docs and cleanup #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force origin/max to be numpy arrays. Change default ordering of regular grid to be fortran renaming centers to centres for english adding cell centres to structure grid/nodes
…formation and ensure dimensionality is used
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 2 comments.
Files not reviewed (10)
- docs/source/getting_started/background.rst: Language not supported
- docs/source/getting_started/installation.rst: Language not supported
- docs/source/index.rst: Language not supported
- docs/source/user_guide/index.rst: Language not supported
- docs/source/user_guide/what_is_a_geological_model.rst: Language not supported
- LoopStructural/init.py: Evaluated as low risk
- LoopStructural/modelling/core/geological_model.py: Evaluated as low risk
- LoopStructural/utils/_surface.py: Evaluated as low risk
- LoopStructural/datatypes/_bounding_box.py: Evaluated as low risk
- LoopStructural/modelling/features/_base_geological_feature.py: Evaluated as low risk
Comments suppressed due to low confidence (1)
LoopStructural/utils/_transformation.py:132
- The
inversedarray might have a shape mismatch ifpointshas more dimensions thanself.dimensions. This should be handled more carefully to avoid runtime errors.
inversed = np.vstack([inversed, points[self.dimensions:]]) if points.shape[1] > self.dimensions else inversed
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…details are given
…al into fix/docs_and_cleanup
…al into fix/docs_and_cleanup
…al into fix/docs_and_cleanup
…al into fix/docs_and_cleanup
…al into fix/docs_and_cleanup
…al into fix/docs_and_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.