Skip to content

Conversation

@lilyminium
Copy link
Member

@lilyminium lilyminium commented May 9, 2025

@lilyminium lilyminium mentioned this pull request May 9, 2025
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the PR is good ✅

The failing tests would need to be addressed:

I don't know how the snapshots are handled (is this documented somewhere?) but something is failing and would need to be fixed, see https://github.com/MDAnalysis/UserGuide/actions/runs/14936015006/job/41963506015?pr=426 . @lilyminium @RMeli do you know?

The formatting should be

from MDAnalysisTests.topology.test_lammpsdata import (
    LammpsBase,
    TestDumpParserFull,
)

says the pre-commit hook check.

@orbeckst
Copy link
Member

It would be good to get this merged so that we can move any of the other PRs along.

@orbeckst orbeckst mentioned this pull request Jul 10, 2025
@orbeckst orbeckst self-assigned this Jul 10, 2025
@RMeli
Copy link
Member

RMeli commented Jul 14, 2025

Sorry, I was OOO. The snapshots might need to be re-generated. I don't recall where this is documented, I'll have a look.

@orbeckst orbeckst assigned RMeli and unassigned orbeckst Jul 14, 2025
@orbeckst
Copy link
Member

Thank you @RMeli !!!

@RMeli
Copy link
Member

RMeli commented Jul 14, 2025

For a release I used the following instructions: https://userguide.mdanalysis.org/stable/preparing_releases_and_hotfixes.html#create-a-release-of-the-userguide.

The section contains instructions on how to generate the snapshots:

cd doc/source/scripts
python -m pytest tests/snapshot/ --snapshot-update

@orbeckst orbeckst self-assigned this Jul 14, 2025
@orbeckst orbeckst merged commit 597af95 into develop Jul 14, 2025
4 checks passed
@orbeckst
Copy link
Member

Thank you @lilyminium and @RMeli !!!

@orbeckst orbeckst deleted the fix-425 branch July 14, 2025 23:58
@lilyminium
Copy link
Member Author

Apologies, I've also been away on travel and GRC -- thanks so much for fixing this Oliver and Rocco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The TestDumpsParser class was removed build_docs fails: cannot import name 'TestDumpParser'

4 participants