Skip to content

test: use C __atomic builtins for debug counters #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantix merged 2 commits into from
Jan 15, 2026
Merged

test: use C __atomic builtins for debug counters #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39111e9
debug: use C __atomic builtins for counters
fantix Jan 15, 2026
4d56638
Also apply on timer handles
fantix Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions uvloop/cbhandles.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ cdef class Handle:
cdef inline _set_loop(self, Loop loop):
self.loop = loop
if UVLOOP_DEBUG:
loop._debug_cb_handles_total += 1
loop._debug_cb_handles_count += 1
system.__atomic_fetch_add(
&loop._debug_cb_handles_total, 1, system.__ATOMIC_RELAXED)
system.__atomic_fetch_add(
&loop._debug_cb_handles_count, 1, system.__ATOMIC_RELAXED)
if loop._debug:
self._source_traceback = extract_stack()

Expand All @@ -21,7 +23,8 @@ cdef class Handle:

def __dealloc__(self):
if UVLOOP_DEBUG and self.loop is not None:
self.loop._debug_cb_handles_count -= 1
system.__atomic_fetch_sub(
&self.loop._debug_cb_handles_count, 1, system.__ATOMIC_RELAXED)
if self.loop is None:
raise RuntimeError('Handle.loop is None in Handle.__dealloc__')

Expand Down Expand Up @@ -174,8 +177,10 @@ cdef class TimerHandle:
self._cancelled = 0

if UVLOOP_DEBUG:
self.loop._debug_cb_timer_handles_total += 1
self.loop._debug_cb_timer_handles_count += 1
system.__atomic_fetch_add(
&self.loop._debug_cb_timer_handles_total, 1, system.__ATOMIC_RELAXED)
system.__atomic_fetch_add(
&self.loop._debug_cb_timer_handles_count, 1, system.__ATOMIC_RELAXED)

if context is None:
context = Context_CopyCurrent()
Expand Down Expand Up @@ -205,7 +210,8 @@ cdef class TimerHandle:

def __dealloc__(self):
if UVLOOP_DEBUG:
self.loop._debug_cb_timer_handles_count -= 1
system.__atomic_fetch_sub(
&self.loop._debug_cb_timer_handles_count, 1, system.__ATOMIC_RELAXED)
if self.timer is not None:
raise RuntimeError('active TimerHandle is deallacating')

Expand Down
8 changes: 8 additions & 0 deletions uvloop/includes/system.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,11 @@ cdef extern from "includes/fork_handler.h":
void setForkHandler(OnForkHandler handler)
void resetForkHandler()
void setMainThreadID(uint64_t id)


cdef extern from * nogil:
uint64_t __atomic_fetch_add(uint64_t *ptr, uint64_t val, int memorder)
uint64_t __atomic_fetch_sub(uint64_t *ptr, uint64_t val, int memorder)

cdef enum:
__ATOMIC_RELAXED