Skip to content

Deps & Refactor & Minor logger enhancement #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pleb merged 11 commits into from
Sep 23, 2025
Merged

Deps & Refactor & Minor logger enhancement #140

pleb merged 11 commits into from
Sep 23, 2025

Conversation

@pleb
Copy link
Contributor

@pleb pleb commented Sep 22, 2025 •
edited
Loading

Changes

  • Upgraded the deps

    • Packages
    • Node 20
    • Eslint 9 + Flat config

  • Refactor

    • Allow reuse of building BaseRequestInfo
      • Add user agent

  • Logger

    • Allow overriding what logger is used by logSubscriptionOperation

Testing

  • Confirmed build output with version 2.2.2, and only expected changes were present

cuzzlor
cuzzlor reviewed Sep 23, 2025
View reviewed changes
cuzzlor
cuzzlor reviewed Sep 23, 2025
View reviewed changes
cuzzlor
cuzzlor reviewed Sep 23, 2025
View reviewed changes
cuzzlor
cuzzlor approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@cuzzlor cuzzlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more naming suggestions basic vs base and the resolveLogger arg into the useSubscriptions function

@pleb pleb merged commit cbc222c into main Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuzzlor cuzzlor cuzzlor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pleb @cuzzlor