MDEV-31255: Crash with fulltext search subquery in explain delete #4523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ft_handler isn't getting initialized for subqueries inside explain delete/update queries. However, ft_handler is accessed inside ha_ft_read(), and is the reason for NULL pointer exception. However, that is not the case with non-explain queries. Earlier, ft_handler initialization is done in the optimizer phase, that too selectively, when the flag SELECT_DESCRIBE is not set, and for derived tables in JOIN_TAB::preread_init(). In this PR, initialization of ft_handler is added inside JOIN_TAB::preread_init() for non derived tables as well, by invoking init_ftfuncs(). One thing to note is that if the ft_handler is initialized earlier, then it doesn't get re-initialized.
bsrikanth-mariadb
force-pushed
the
10.11-MDEV-31255-explain-delete-failure-with-fulltext-search-subquery
branch
from
bd69d0f to
ce070d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ft_handler isn't getting initialized for subqueries inside explain
delete/update queries. However, ft_handler is accessed inside ha_ft_read(),
and is the reason for NULL pointer exception.
However, that is not the case with non-explain queries.
Earlier, ft_handler initialization is done in the optimizer phase, that too
selectively, when the flag SELECT_DESCRIBE is not set, and for derived
tables in JOIN_TAB::preread_init().
In this PR, initialization of ft_handler is added inside
JOIN_TAB::preread_init() for non derived tables as well, by invoking
init_ftfuncs(). One thing to note is that if the ft_handler is initialized
earlier, then it doesn't get re-initialized.