MDEV-38550: [10.6] Fix COM_CHANGE_USER for long passwords #4534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkodinov
added
the
External Contribution
gkodinov
requested changes
Jan 13, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Please use https://jira.mariadb.org/browse/MDEV-38550 instead of the original one.
Author
|
Will continue working on this after #4509 got merged. |
rophy
force-pushed
the
fix/MDEV-38431-2
branch
from
e735668 to
497027f
Compare
rophy
changed the title
rophy
force-pushed
the
fix/MDEV-38431-2
branch
2 times, most recently
from
caa5f1c to
43678d9
Compare
Add support for CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA in COM_CHANGE_USER packet parsing, allowing passwords >= 251 bytes. Changes: - Server: parse_com_change_user_packet() now handles LENENC-encoded password length when CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA is set - Server: fix db pointer calculation for old protocol without CLIENT_SECURE_CONNECTION (need +1 to skip null terminator) - Add regression test for COM_CHANGE_USER with long passwords Note: This fix requires a corresponding client-side fix in libmariadb's send_change_user_packet() to send LENENC-encoded passwords.
rophy
force-pushed
the
fix/MDEV-38431-2
branch
from
43678d9 to
4fa4bbe
Compare
Author
|
Updated. The CI tests will not pass until both server and libmariadbclient are fixed. How do we manage such circular deps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4509, which focuses on auth switch. This PR focuses on COM_CHANGE_USER.