Skip to content

<fix>[virtualRouterProvider]: fix backup lb vip refresh #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-1 wants to merge 1 commit into
base: 5.5.0
Choose a base branch
from
Open

<fix>[virtualRouterProvider]: fix backup lb vip refresh #3146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...in/java/org/zstack/network/service/virtualrouter/lb/VirtualRouterLoadBalancerBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ private List<LbTO> makeLbTOs(final LoadBalancerStruct struct, VirtualRouterVmInv
VipInventory vipInUsed = vip == null ? vip6 : vip;
VmNicInventory publicNic = null;

if (vr != null) {
if (vr != null && vipInUsed != null) {
List<VmNicInventory> nics = vr.getVmNics().stream()
.filter(n -> StringUtils.equals(n.getL3NetworkUuid(), vipInUsed.getL3NetworkUuid()))
.collect(Collectors.toList());
Expand Down Expand Up @@ -2763,6 +2763,10 @@ public void callBack(String vrUuid, VirtualRouterHaTask task, Completion complet
}

LoadBalancerStruct s = JSONObjectUtil.toObject(task.getJsonData(), LoadBalancerStruct.class);
logger.debug(String.format("Refreshing LB[uuid:%s] on backup VR[uuid:%s], clearing VIP to avoid dual-master",
s.getLb().getUuid(), vrUuid));
s.setVip(null);
s.setIpv6Vip(null);
refreshLbToVirtualRouter(VirtualRouterVmInventory.valueOf(vrVO), s, completion);
}
};
Expand Down