Skip to content

<fix>[conf]: add i18n "volume[uuid:%s] has been deleted"#3389

Closed
ZStack-Robot wants to merge 1 commit intozsv_5.0.0from
sync/zstackio/ZSV-5838@@2
Closed

<fix>[conf]: add i18n "volume[uuid:%s] has been deleted"#3389
ZStack-Robot wants to merge 1 commit intozsv_5.0.0from
sync/zstackio/ZSV-5838@@2

Conversation

@ZStack-Robot
Copy link
Collaborator

the volume can be deleted and if users want to recover the vm
through the snapshot that took after binding the aforesaid volume
, the system may complain the null pointer exception because we do
not check if the volumes are deleted or not.

Resolves: ZSV-5838

Change-Id: I636c626d7372676776637661766d626466707a72

sync from gitlab !9237

the volume can be deleted and if users want to recover the vm
through the snapshot that took after binding the aforesaid volume
, the system may complain the null pointer exception because we do
not check if the volumes are deleted or not.

Resolves: ZSV-5838

Change-Id: I636c626d7372676776637661766d626466707a72
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65cdaac and 98e2c1c.

⛔ Files ignored due to path filters (1)
  • conf/i18n_json/i18n_zsv.json is excluded by !**/*.json
📒 Files selected for processing (2)
  • conf/i18n/messages_en_US.properties
  • conf/i18n/messages_zh_CN.properties

工作流程

向国际化消息配置文件中添加了新的翻译条目。英文版本新增了一条关于卷删除的消息。中文版本新增了多条消息,涵盖卷删除、SSH连接失败和DNS检查失败等场景,并对现有消息进行了格式调整。

变更

结构类型 / 文件 摘要
国际化消息配置
conf/i18n/messages_en_US.properties
新增一条卷删除提示信息。
国际化消息配置
conf/i18n/messages_zh_CN.properties
新增三条消息条目,包括卷删除提示、SSH密码连接失败和DNS检查无法连接的错误信息。现有主机密码修改相关消息进行了行格式调整。

评估代码审查工作量

🎯 2 (Simple) | ⏱️ ~12 分钟

诗歌

🐰 新的翻译来报到,
卷删除有了说法,
SSH和DNS不再躲,
消息清晰又友好,
国际化更上一层楼呀!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR标题准确总结了主要变化:添加了一个国际化消息条目,用于表示数据卷被删除的情况。
Description check ✅ Passed PR描述清楚地解释了变更的背景和原因:数据卷删除后恢复虚拟机时可能出现空指针异常,需要添加相关的国际化消息提示。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync/zstackio/ZSV-5838@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

@zstack-robot-1 zstack-robot-1 deleted the sync/zstackio/ZSV-5838@@2 branch February 26, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants