<fix>[conf]: add i18n "volume[uuid:%s] has been deleted"#3389
Closed
ZStack-Robot wants to merge 1 commit intozsv_5.0.0from
Closed
<fix>[conf]: add i18n "volume[uuid:%s] has been deleted"#3389ZStack-Robot wants to merge 1 commit intozsv_5.0.0from
ZStack-Robot wants to merge 1 commit intozsv_5.0.0from
Conversation
the volume can be deleted and if users want to recover the vm through the snapshot that took after binding the aforesaid volume , the system may complain the null pointer exception because we do not check if the volumes are deleted or not. Resolves: ZSV-5838 Change-Id: I636c626d7372676776637661766d626466707a72
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
工作流程向国际化消息配置文件中添加了新的翻译条目。英文版本新增了一条关于卷删除的消息。中文版本新增了多条消息,涵盖卷删除、SSH连接失败和DNS检查失败等场景,并对现有消息进行了格式调整。 变更
评估代码审查工作量🎯 2 (Simple) | ⏱️ ~12 分钟 诗歌
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the volume can be deleted and if users want to recover the vm
through the snapshot that took after binding the aforesaid volume
, the system may complain the null pointer exception because we do
not check if the volumes are deleted or not.
Resolves: ZSV-5838
Change-Id: I636c626d7372676776637661766d626466707a72
sync from gitlab !9237