Skip to content

fix type hinting#179

Merged
Pierre-siddall merged 1 commit intoMetOffice:mainfrom
james-bruten-mo:type_hinting_issue
Feb 4, 2026
Merged

fix type hinting#179
Pierre-siddall merged 1 commit intoMetOffice:mainfrom
james-bruten-mo:type_hinting_issue

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Feb 4, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @Pierre-siddall

The type hinting syntax doesn't work with the default python version for rose-stem. Switching back to using Union.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change type hinting is corrected, therefore this looks good to me, thanks James.

@Pierre-siddall Pierre-siddall merged commit 366f3bb into MetOffice:main Feb 4, 2026
13 checks passed
@jennyhickson jennyhickson added this to the Spring 2026 milestone Feb 4, 2026
r-sharp pushed a commit to r-sharp/SimSys_Scripts that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants