feat: use dynamic supported networks from Price API #7716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) { | ||
| lastFetchedSupportedNetworks = response as SupportedNetworksResponse; | ||
| return lastFetchedSupportedNetworks; | ||
| } |
There was a problem hiding this comment.
Incomplete API response validation causes runtime crash
Medium Severity
The validation in fetchSupportedNetworks only checks for fullSupport and partialSupport top-level properties but doesn't verify the nested structure. If the API returns { fullSupport: [], partialSupport: {} } (missing spotPricesV3), the validation passes, the malformed response gets cached, and getSupportedChainIdsV3AsHex will crash when spreading undefined from partialSupport.spotPricesV3.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current State
The
CodefiTokenPricesServiceV2inassets-controllersuses a hardcoded list (SPOT_PRICES_SUPPORT_INFO) to determine which blockchain networks are supported by the Price API's/v3/spot-pricesendpoint. This approach has several drawbacks:Additionally, the native asset CAIP-19 identifiers (e.g.,
eip155:1/slip44:60for ETH) were also hardcoded, duplicating data that already exists inNetworkEnablementController.state.nativeAssetIdentifiers.Solution
This PR introduces dynamic fetching of supported networks from the Price API's
/v2/supportedNetworksendpoint:fetchSupportedNetworks()function that fetches from/v2/supportedNetworksand caches the responsefetchTokenPrices()callsetNativeAssetIdentifiers()method to receive native asset mappings fromNetworkEnablementController, eliminating duplicationnativeAssetIdentifiersfromNetworkEnablementControllerto the token prices serviceChanges Summary
codefi-v2.ts: Added dynamic network fetching, caching, and native asset identifier supportabstract-token-prices-service.ts: AddedNativeAssetIdentifiersMaptype and optionalsetNativeAssetIdentifiers()method to interfaceTokenRatesController.ts: Integrated withNetworkEnablementControllerto pass native asset identifiers@metamask/network-enablement-controlleras a dependencyReferences
https://price.api.cx.metamask.io/v2/supportedNetworksNetworkEnablementController.state.nativeAssetIdentifiersfor CAIP-19 native token mappingsChecklist
Note
Introduces dynamic network support and native asset ID integration for token pricing.
/v2/supportedNetworksintegration intoken-prices-servicewith caching, background refresh, and fallback; exportfetchSupportedNetworks,getSupportedNetworks,resetSupportedNetworksCacheCodefiTokenPricesServiceV2to: acceptsetNativeAssetIdentifiers(), build CAIP-19 for natives via provided map, validate chains via dynamic lists, and exposeupdateSupportedNetworks()TokenRatesControllernow callsNetworkEnablementController:getStateto passnativeAssetIdentifiersinto the token price service on initNativeAssetIdentifiersMapand optionalsetNativeAssetIdentifiers(); update exports and tests accordingly@metamask/network-enablement-controllerdependency and TypeScript project referencesWritten by Cursor Bugbot for commit 863782e. This will update automatically on new commits. Configure here.