refactor: Make makeJsonAgent bundleable with @endo/bundle-source #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grypez
force-pushed
the
grypez/refactor-kernel-errors-libp2p
branch
from
d349ac7 to
1cd0e2b
Compare
grypez
force-pushed
the
grypez/add-skill-create-package
branch
from
b817127 to
d269097
Compare
grypez
force-pushed
the
grypez/refactor-kernel-errors-libp2p
branch
from
1cd0e2b to
6de5dee
Compare
grypez
changed the title
grypez
force-pushed
the
grypez/refactor-kernel-errors-libp2p
branch
from
6de5dee to
6c9d512
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This refactors kernel-utils and kernel-errors to enable makeJsonAgent to be bundled into vats using @endo/bundle-source. Changes: - kernel-utils: Added subpath exports (counter, merge-disjoint-records, schema) - kernel-errors: Added bundleable subpath with simplified error classes - kernel-errors: Extracted ErrorCode to error-codes.ts (no @metamask/utils dep) - ocap-kernel: Moved isRetryableNetworkError from kernel-errors to utils - kernel-agents: Updated to use subpath imports The bundler was failing due to transitive dependencies on @noble/hashes which has ESM/CJS compatibility issues. By using subpath exports and moving libp2p-specific code to ocap-kernel, we avoid pulling in unbundleable dependencies.
grypez
force-pushed
the
grypez/refactor-kernel-errors-libp2p
branch
2 times, most recently
from
23637c2 to
ef88bc2
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
grypez
force-pushed
the
grypez/refactor-kernel-errors-libp2p
branch
from
ef88bc2 to
3a34ff1
Compare
rekmarks
reviewed
Jan 21, 2026
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
I don't love the idea of complicating our package exports due to deficiencies in @endo/bundle-source, in this case complaining about dependencies that aren't actually used. Since we need to support mainstream bundlers at some point anyway, I'd rather we figure out how to do this with Vite.
Member
|
Superceded by #763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors kernel-utils and kernel-errors to enable makeJsonAgent to be bundled into vats using @endo/bundle-source.
Changes:
The bundler was failing due to transitive dependencies on @noble/hashes (through @metamask/utils) which has ESM/CJS compatibility issues. By using subpath exports and moving libp2p-specific code to ocap-kernel, we avoid pulling in unbundleable dependencies.
Note
Makes
makeJsonAgentbundleable with @endo/bundle-source by reducing cross-package deps and introducing bundle-safe entry points.ErrorCodetoerror-codes.ts, addsisSampleGenerationErrortype guard, introducesbundleable/(incl.SampleGenerationError), updates exports, and adds tests; removes libp2p-related dependency.counter,merge-disjoint-records, andschema; re-exportsmakeCounterfrom new module.SampleGenerationError/isSampleGenerationError.isRetryableNetworkErrorhere (utils/), updatesremotesto use it.Written by Cursor Bugbot for commit 3a34ff1. This will update automatically on new commits. Configure here.