refactor(coverage): Replace per-package thresholds with GitHub Actions workflow #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s workflow - Remove per-package coverage thresholds from vitest.config.ts to eliminate merge conflicts - Add 'json-summary' reporter for coverage reporting - Delete reset-coverage-thresholds.sh script and pretest hook - Create coverage.yml workflow that: - Runs tests with coverage on PR and base branches in parallel - Uploads coverage as artifacts (7-day retention) - Posts PR comments with coverage totals and deltas using vitest-coverage-report-action - No coverage data stored in repo, preventing conflicts while enabling trend tracking Co-Authored-By: Claude <noreply@anthropic.com>
- Deploy HTML coverage report to GitHub Pages on push to main - Add PR comment with link to main branch coverage report - Fix action versions (use v4 for checkout/artifact actions) - Use dawidd6/action-download-artifact for cross-workflow artifact download Coverage report will be available at: https://metamask.github.io/ocap-kernel/coverage/ Co-Authored-By: Claude <noreply@anthropic.com>
…le report workflow - Add coverage job to lint-build-test.yml to collect coverage artifacts - Create coverage-report.yml as reusable workflow for PR comments and GitHub Pages - Call coverage-report from main.yml after lint-build-test - Remove standalone coverage.yml (duplicate functionality) - Coverage now collected as part of main CI instead of running tests twice Coverage report will be available at: https://metamask.github.io/ocap-kernel/coverage/ Co-Authored-By: Claude <noreply@anthropic.com>
- Remove cache save/restore steps from workflows - Fetch baseline coverage-summary.json from gh-pages URL on PRs - Reduce artifact retention to 7 days (only needed within workflow run) - Simplifies to only official GitHub actions, no third-party dependencies - Gracefully handles first run when baseline doesn't exist yet Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Note: The "Coverage report" job is expected to fail until the modified workflows have run on |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vitest.config.tsChanges
vitest.config.tsscripts/reset-coverage-thresholds.shand pretest hook.github/workflows/coverage-report.ymlCoverage Report
main🤖 Generated with Claude Code
Note
Introduces CI-driven coverage and removes brittle per-package thresholds.
coverage-report.ymlworkflow: downloads coverage artifact, publishes HTML to GitHub Pages onmain, fetches baseline on PRs, posts coverage diff viadavelosert/vitest-coverage-report-action, and comments a link to the full reportmain.ymlafterlint-build-test; skips onmerge_grouplint-build-test.ymlto run tests with--coverageonly on Node24.xand upload thecoverage/artifactpackage.json: removespretesthook,test:ci, andscripts/reset-coverage-thresholds.sh; keepstestasvitest runvitest.config.tscoverage reporters to includejson-summaryand removes the large per-packagethresholdsblockWritten by Cursor Bugbot for commit 3f9517a. This will update automatically on new commits. Configure here.