-
Notifications
You must be signed in to change notification settings - Fork 642
release: 139.0.0
#3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 139.0.0
#3813
Conversation
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| }, | ||
| "source": { | ||
| "shasum": "bLh42RUBGIcHxVrXiOOyYxFE4tMsZq3choYigIuOHX0=", | ||
| "shasum": "4+7ZgHt849j2sZQAwxlkGQ4il80SRXMmDYvb7h0+PrI=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extended manifest shasum not updated with base manifest
Medium Severity
The snap.manifest.json shasum was updated to 4+7ZgHt849j2sZQAwxlkGQ4il80SRXMmDYvb7h0+PrI= in this release, but snap.manifest.dev.json in the same package still has a different shasum (yW/4a7WQ2dCmZHAaX6P2tihFF7azVPkpQ0iJlb/v61A=). Since both manifests reference the same bundle (dist/bundle.js), they should have matching shasums. Using the dev manifest for development would fail bundle verification.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3813 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 430 430
Lines 12340 12340
Branches 1919 1919
=======================================
Hits 12137 12137
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is the release candidate for version
139.0.0.Note
Release highlights
snaps-execution-environments@10.4.0,snaps-rpc-methods@14.2.0,snaps-sdk@10.4.0,snaps-jest@10.0.0, andsnaps-simulation@4.0.0--manifestflag insnaps-cli@8.4.0; updatesnaps-utils@12.0.0withloadManifestand breaking manifest checks; bumpsnaps-rollup-plugin@5.0.1andsnaps-webpack-plugin@5.1.2to use it@metamask/multichain-provider-example-snap@1.0.0and update Test Snaps to include itplatformVersion10.4.0and refresh bundleshasumsNotable breaking changes
snaps-jest@10.0.0andsnaps-simulation@4.0.0: default account used by selectors changedsnaps-utils@12.0.0:checkManifestnow requires a manifest path and supports extendable manifestsWritten by Cursor Bugbot for commit 6e43a46. This will update automatically on new commits. Configure here.