Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 23, 2026

We no longer need the closeAllConnections constructor argument since we properly emit events for torn down streams which in turn closes the connection on the extension-side. This never did anything on mobile.

For reference: #3074


Note

Breaking API cleanup in SnapController.

  • Removes closeAllConnections type, constructor parameter, private field, and assignment
  • Drops call to #closeAllConnections in stopSnap, relying solely on #terminateSnap
  • Updates test helpers to no longer pass closeAllConnections in controller options

Written by Cursor Bugbot for commit 712f81a. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 23, 2026 13:11
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (afc2c54) to head (712f81a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3814      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         430      430              
  Lines       12340    12338       -2     
  Branches     1919     1919              
==========================================
- Hits        12137    12135       -2     
  Misses        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit f246f4a Jan 23, 2026
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-close-connections-arg branch January 23, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants