refactor!: Remove closeAllConnections constructor argument
#3814
+0
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need the
closeAllConnectionsconstructor argument since we properly emit events for torn down streams which in turn closes the connection on the extension-side. This never did anything on mobile.For reference: #3074
Note
Breaking API cleanup in
SnapController.closeAllConnectionstype, constructor parameter, private field, and assignment#closeAllConnectionsinstopSnap, relying solely on#terminateSnapcloseAllConnectionsin controller optionsWritten by Cursor Bugbot for commit 712f81a. This will update automatically on new commits. Configure here.