-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ensure all blocks have renders & distinct names in gui #5972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crosby-moe
wants to merge
19
commits into
MeteorDevelopment:master
Choose a base branch
from
crosby-moe:fix/gui-block-renders
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ensure all blocks have renders & distinct names in gui #5972
crosby-moe
wants to merge
19
commits into
MeteorDevelopment:master
from
crosby-moe:fix/gui-block-renders
+574
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
i also looked into dynamically generating item models as needed instead of adding them all to the repo, but that is unfortunately very difficult to get working (something something data dependencies & having to first load all referenced block models) |
This reverts commit 297f920.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
for the renders:
meteor-clientnamespace to prevent funny business)for the names, for some reason the 'Wall' part of blocks is always omitted
unfortunately, this replacement can only be done in english languages (because it was manually mapped), so support for other languages will probably be added some time after meteor supports translations
Related issues
none
How Has This Been Tested?
the J
Checklist: