Skip to content

Conversation

@emancilla77
Copy link

Closes: #89

Issues:

  • "Redundant final modifier" error passed from checkstyle for 3 lines, but removal of final operator creates "parameter needs final modifier" issue. This is rooted in a conflict in the checkstyle config, not my code itself

Copy link
Contributor

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments.

Also remove build artifact ConsoleGameHub.jar from this PR.

Comment on lines +206 to +207
public LightsOutBoard generateSolvable(final int rows,
final int cols, final Random rng);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to be a compilation error. Please provide documentation of an error-free build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in your comment that you identified "checkstyle" errors here. I think that's likely to be a result of this not being correct Java, which is a precondition for meaningful usage of checkstyle.

Looking at the code, it appears that you're tyring to define an abstract class called BoardGenerator, and an abstract method within that class called generateSolvable. But there's no abstract keyword on either.

Or it could be that generateSolvable was meant to be a method stub. In that case there needs to be a body defined that at least returns the proper data type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Internal design of Lights Out game as stubbed source code

2 participants