Implemented User Story #37: Highlight current game title before play starts #147
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a "Now Playing" header when a game is launched and includes a test line in the README. The changes appear to be incomplete as they contain a placeholder line meant to be deleted.
- Added a game launch announcement that displays the game name in uppercase
- Introduced a test line in README.md that should be removed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Added test placeholder text that appears intended for deletion |
| GameLauncher.java | Added console output to display the currently playing game name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,5 @@ | |||
| # Console Game Hub | |||
| test-delete this | |||
There was a problem hiding this comment.
This line appears to be a test placeholder that should be removed before merging. It does not belong in the project documentation.
| test-delete this |
| System.out.println("Goodbye!"); | ||
| } else if (choice > 0 && choice <= this.games.size()) { | ||
| Game game = this.games.get(choice - 1); | ||
| System.out.println("\n=== Now Playing: " + game.getName().toUpperCase() + " ==="); |
There was a problem hiding this comment.
The indentation uses tabs while the surrounding code uses spaces. This line should use consistent indentation with spaces to match the rest of the file (appears to be 20 spaces based on surrounding lines).
| System.out.println("\n=== Now Playing: " + game.getName().toUpperCase() + " ==="); | |
| System.out.println("\n=== Now Playing: " + game.getName().toUpperCase() + " ==="); |
There was a problem hiding this comment.
This PR seems to introduce some unintended artifacts into the README.md. Specifically, the line 'test-delete this' looks like temporary development text. Please clean up all non-essential or temporary content.
|
Please include demonstration that the changes proposed (a) have associated tests; (b) do not cause previously passing tests to fail; (c) are consistent with project coding conventions. |
2 participants
Added a formatted “Now Playing” message in GameLauncher.java to display the current game name before the game begins.
This implements User Story #37 from the MetroCS ConsoleGameHub project.