This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Use default appsDirectory parm in deploy goal #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #388. |
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
scottkurz
force-pushed
the
fix-generated-non-default-app-location
branch
from
c94ca75 to
e50bbbc
Compare
cherylking
previously approved these changes
Sep 16, 2019
Contributor
Author
|
This doesn't work because LMP looks for the app configured in src server.xml but Boost is generating it into target server.xml. https://github.com/OpenLiberty/ci.maven/blob/master/liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/PluginConfigSupport.java#L322-L329 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Kurz skurz@us.ibm.com