Skip to content

Conversation

@afbjorklund
Copy link
Contributor

This was "commented out" in the dockershim tests (of critest)

kubernetes-sigs/cri-tools@4bb6714#diff-fb3f779b47c369fad04d8812ff6e9d8fa84fd10dededf3bea1cf6de29b6f7ecdR258

        // NOTE: dockershim does not populate that field, so we do not have to test it
        if framework.TestContext.RuntimeServiceAddr != framework.DockerShimSockPathUnix &&
                framework.TestContext.RuntimeServiceAddr != framework.DockerShimSockPathWindows {
                By("verifying container status mount propagation")
                Expect(resp.Status.Mounts[0].Propagation).To(Equal(propagation))
        }

@nwneisen nwneisen force-pushed the master branch 2 times, most recently from 6f4e576 to 15fa56a Compare June 21, 2023 02:06
@afbjorklund afbjorklund force-pushed the propagation branch 2 times, most recently from dafa44d to 3c5e5c5 Compare December 22, 2023 16:34
@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jun 28, 2024

Still broken, with v1.30.0

Summarizing 2 Failures:
  [FAIL] [k8s.io] Container Mount Propagation runtime should support mount propagation [It] mount with 'rshared' should support propagation from host to container and vice versa
  github.com/kubernetes-sigs/cri-tools/pkg/validate/container_linux.go:265
  [FAIL] [k8s.io] Container Mount Propagation runtime should support mount propagation [It] mount with 'rslave' should support propagation from host to container
  github.com/kubernetes-sigs/cri-tools/pkg/validate/container_linux.go:265

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jan 3, 2025

Fixes the two issues, with v1.32.0


CI tests are broken:

Local results:

Ran 96 of 113 Specs in 263.840 seconds
FAIL! -- 75 Passed | 21 Failed | 0 Pending | 17 Skipped

Mostly due to missing log support.

(And some AppArmor and networking.)

@afbjorklund
Copy link
Contributor Author

@nwneisen

@afbjorklund
Copy link
Contributor Author

Still broken, as far as I know. But I guess nobody runs critest anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant