Skip to content

Comments

Replace pre-commit with prek#130

Open
Miyamura80 wants to merge 2 commits intomainfrom
prek-setup-5576607088466303257
Open

Replace pre-commit with prek#130
Miyamura80 wants to merge 2 commits intomainfrom
prek-setup-5576607088466303257

Conversation

@Miyamura80
Copy link
Owner

Replaced pre-commit with prek as requested. This includes:

  • Adding prek to pyproject.toml dev dependencies.
  • Creating prek.toml with the same hooks as .pre-commit-config.yaml.
  • Removing .pre-commit-config.yaml.
  • Updating Makefile setup_githooks and install_tools targets to use prek.
  • Adding documentation for prek in .claude/skills/prek/SKILL.md.

Verified by running prek run --all-files which passed all checks.
Note: make ci fails due to pre-existing type errors in utils/llm/dspy_langfuse.py, unrelated to these changes.


PR created automatically by Jules for task 5576607088466303257 started by @Miyamura80

- Install prek as a dev dependency
- Create prek.toml configuration
- Remove .pre-commit-config.yaml
- Update Makefile to use prek for githooks and tool installation
- Add prek skill documentation in .claude/skills/prek/SKILL.md

Co-authored-by: Miyamura80 <38335479+Miyamura80@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR successfully replaces pre-commit with prek as a faster, Rust-based alternative for managing git hooks. All hooks from .pre-commit-config.yaml were correctly migrated to prek.toml with identical configuration. The changes include:

  • Added prek>=0.3.3 to dev dependencies in pyproject.toml
  • Created prek.toml with all 8 hooks (check-added-large-files, lint-links, make-fmt, ruff-check, ruff-complexity, ruff-tech-debt, pylint-duplicate-code, ai-writing-check)
  • Updated Makefile targets (setup_githooks and install_tools) to use prek install and uv tool install prek
  • Removed .pre-commit-config.yaml
  • Added comprehensive documentation in .claude/skills/prek-precommit-hook/SKILL.md

The migration is complete and validated by the author running prek run --all-files successfully.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Clean migration from pre-commit to prek with complete feature parity. All 8 hooks preserved with identical configuration, Makefile properly updated, dependency correctly added, and documentation provided. Author verified functionality by running prek successfully. No logic changes, security concerns, or breaking changes.
  • No files require special attention

Important Files Changed

Filename Overview
.claude/skills/prek-precommit-hook/SKILL.md New skill documentation added for prek usage and commands
Makefile Updated setup_githooks and install_tools targets to use prek instead of pre-commit
prek.toml New prek configuration with same hooks as previous pre-commit setup
pyproject.toml Added prek>=0.3.3 to dev dependencies

Last reviewed commit: 112d883

- Install prek as a dev dependency
- Create prek.toml configuration from existing hooks
- Remove .pre-commit-config.yaml
- Update Makefile to use prek for githooks and tool installation
- Add prek-precommit-hook skill documentation in .claude/skills/prek-precommit-hook/SKILL.md

Co-authored-by: Miyamura80 <38335479+Miyamura80@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant