Update (port to ModbusSim)

[jgeudens]

Summary by CodeRabbit

• Documentation

  • Updated project branding to ModbusSim, including README text, demo image and build badge; replaced header with inline logo.

• Improvements

  • Increased main window width and improved table column sizing behaviour; updated window title and header visibility.

• Chores

  • Added new configuration option sequence_diagrams: false.
  • Updated deployment assets to use a higher-resolution application icon.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR adds a new sequence_diagrams option (set to false) in .coderabbit.yaml, and renames project branding from ModbusTestSlave to ModbusSim across README and assets. README badges, headings and demo image references were updated. scripts/deploy_linux.sh now copies misc/icon/icon-256x256.png for ModbusSim.png. UI changes: src/mainwindow.ui width increased (700→1021) and Qt enums made scoped. src/mainwindow.cpp/.h adjust constructor spacing, change header resize behaviour to Stretch, and update the window title to "ModbusSim".

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check	❓ Inconclusive	The title 'Update (port to ModbusSim)' is vague and lacks specificity about the actual changes in the pull request.	Consider using a more descriptive title that clearly indicates the main changes, such as 'Rebrand ModbusTestSlave to ModbusSim' or 'Update documentation and assets for ModbusSim rebranding'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6a0b10 and 08ff191.

📒 Files selected for processing (3)

• README.md (1 hunks)
• src/mainwindow.cpp (3 hunks)
• src/mainwindow.h (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

src/mainwindow.cpp (1)

src/mainwindow.h (1)

• MainWindow (18-53)

src/mainwindow.h (1)

src/mainwindow.cpp (2)

• MainWindow (9-82)
• MainWindow (84-95)

🪛 LanguageTool

README.md

[duplication] ~5-~5: Possible typo: you repeated a word.
Context: .../actions/workflows/ccpp.yml) # What is ModbusSim ModbusSim is a Modbus slave test application for ...

(ENGLISH_WORD_REPEAT_RULE)

🔇 Additional comments (10)

src/mainwindow.cpp (4)

5-5: LGTM!

The QDebug include is necessary for the qDebug() calls used on lines 110 and 128.

---

9-9: LGTM!

The pointer style change is consistent with the header file declaration and maintains consistency across the codebase.

---

66-67: LGTM!

The horizontal header is now properly configured to show and stretch columns to fill available space. The contradictory comment from the previous review has been correctly removed.

---

79-79: LGTM!

The window title has been correctly updated to "ModbusSim" as part of the rebranding effort.

src/mainwindow.h (2)

5-5: LGTM!

The include reordering and pointer style changes maintain consistency. The constructor signature matches the implementation in mainwindow.cpp.

Also applies to: 8-8, 11-11, 23-23

---

37-37: LGTM!

The pointer style changes for member variables are consistent with the overall code style improvements in this PR.

Also applies to: 49-50, 52-52

README.md (4)

1-1: LGTM!

The logo image enhances the README presentation and aligns with the rebranding to ModbusSim.

---

3-3: LGTM!

The build status badge has been correctly updated to reference the ModbusSim repository.

---

8-12: LGTM!

The key features list provides clear, valuable information about ModbusSim's capabilities.

---

14-14: LGTM!

The demo image reference has been correctly updated to ModbusSim.png.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

src/mainwindow.ui (1)

9-9: Verify the window width increase is intentional.

The main window width has increased from 700 to 1021 pixels (approximately 45%). Whilst this aligns with the column stretch behaviour change in mainwindow.cpp, please confirm this significant size increase is intentional and doesn't negatively impact users with smaller displays.

src/mainwindow.cpp (1)

9-9: Consider consistent pointer style formatting.

The constructor implementation uses QWidget* parent whilst the header declaration (shown in the relevant code snippets) uses QWidget *parent. For consistency, consider aligning the pointer style between the header and implementation.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80b11c6 and b6a0b10.

⛔ Files ignored due to path filters (5)

• ModbusSim.png is excluded by !**/*.png
• ModbusTestSlave.png is excluded by !**/*.png
• misc/icon/Icons8_flat_sim_card.svg is excluded by !**/*.svg
• misc/icon/icon-256x256.png is excluded by !**/*.png
• misc/icon/icon-64x64.png is excluded by !**/*.png

📒 Files selected for processing (5)

• .coderabbit.yaml (1 hunks)
• README.md (1 hunks)
• scripts/deploy_linux.sh (1 hunks)
• src/mainwindow.cpp (3 hunks)
• src/mainwindow.ui (6 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/mainwindow.cpp (1)

src/mainwindow.h (1)

• MainWindow (18-54)

🪛 LanguageTool

README.md

[duplication] ~5-~5: Possible typo: you repeated a word.
Context: .../actions/workflows/ccpp.yml) # What is ModbusSim ModbusSim is an application that can be used to t...

(ENGLISH_WORD_REPEAT_RULE)

---

[grammar] ~6-~6: After the number ‘2’, use a plural noun. Did you mean “sets”?
Context: ...ter. The application consists of 2 main set of modules. A GUI-less part that contai...

(CD_NNU)

🔇 Additional comments (5)

.coderabbit.yaml (1)

12-12: LGTM!

The sequence_diagrams configuration option is valid and correctly set to false to disable sequence diagram generation in walkthroughs.

scripts/deploy_linux.sh (1)

6-6: LGTM!

Upgrading to the higher resolution 256×256 icon improves visual quality for the AppImage, particularly on high-DPI displays.

README.md (1)

1-1: LGTM!

The branding updates consistently reflect the ModbusSim naming across logo, build badge, and demo image references.

Also applies to: 3-3, 8-8

src/mainwindow.ui (1)

31-31: LGTM!

Updating Qt enums to use scoped syntax (e.g., Qt::LayoutDirection::LeftToRight, Qt::Orientation::Horizontal) is good modernisation and improves Qt 6 compatibility.

Also applies to: 100-100, 128-128, 188-188, 234-234

src/mainwindow.cpp (1)

66-66: LGTM!

The horizontal header visibility and window title updates correctly reflect the UI improvements and rebranding to ModbusSim.

Also applies to: 81-81