feat(mcp): remove mcp-session-id header injection for HTTP transports #681
+6
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
xiaoju111a
force-pushed
the
feat/mcp-skip-session-id
branch
from
af1dd4f to
f052b45
Compare
xiaoju111a
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes incorrect manual injection of the Mcp-Session-Id header for HTTP MCP transports, fixing connection failures with MCP servers like Linear and DeepWiki that were rejecting client-generated session IDs.
Changes:
- Removed 9 lines of code that manually added
Mcp-Session-Idheader to non-OAuth HTTP MCP server configurations - Session management is now delegated entirely to the fastmcp library, which handles the MCP protocol correctly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #677
Description
This PR fixes incorrect manual addition of
Mcp-Session-Idheader that violated the MCP protocol standard.Problem
The previous implementation manually added
Mcp-Session-Idheader using kimi-cli's session ID, which violated the MCP protocol standard. According to MCP specification (2025-06-18), theMcp-Session-Idmust be:initializerequestThis caused connection failures with MCP servers like Linear and DeepWiki, which returned
400 Bad Request: Session not foundbecause they didn't recognize the client-generated session ID.Solution
Removed the incorrect manual
Mcp-Session-Idheader injection logic and let the fastmcp library handle session management automatically according to the MCP protocol standard:initializerequest withoutMcp-Session-IdMcp-Session-Idin response headerChanges
Modified files:
src/kimi_cli/soul/toolset.py: Removed manualMcp-Session-Idheader injection logic (9 lines deleted)Testing
Verified with both Linear (OAuth) and DeepWiki (non-OAuth) MCP servers:
Checklist
CHANGELOG.md). (Will be added in a separate commit)