Skip to content

NRL-1811 do not log multiple pointer warning if test patient #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
katebobyn-nhs wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

NRL-1811 do not log multiple pointer warning if test patient #1114

katebobyn-nhs wants to merge 3 commits into from

Conversation

@katebobyn-nhs
Copy link
Contributor

@katebobyn-nhs katebobyn-nhs commented Dec 29, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

🚀 PR environment successfully deployed.
Commit Hash: 27575fae82b66b921e40bad46c28db531d8752a6
URL: https://nrl1811-01ba47.api.record-locator.dev.national.nhs.uk/

sandyforresternhs
sandyforresternhs reviewed Dec 30, 2025
View reviewed changes
Copy link
Contributor

@sandyforresternhs sandyforresternhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍 . We've got tests that assert logs are created when multiple pointers are detected - would it be worth adding an assertion to show it doesn't log in relation to test patients?

@katebobyn-nhs katebobyn-nhs marked this pull request as ready for review December 31, 2025 09:03
@katebobyn-nhs katebobyn-nhs requested a review from a team as a code owner December 31, 2025 09:03
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

💥 Something went wrong while building the pull request environment.
Check Output Logs

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

🚀 PR environment successfully deployed.
Commit Hash: fef2379e63d1dcaebc0299669fd8b35116cee9f6
URL: https://nrl1811-01ba47.api.record-locator.dev.national.nhs.uk/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandyforresternhs sandyforresternhs sandyforresternhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katebobyn-nhs @sandyforresternhs