GPCAPIM-190 - Poetry dependency approach to consuming code from common repo #30
Conversation
Vox-Ben
left a comment
Vox-Ben
left a comment
There was a problem hiding this comment.
Two minor comments worth having a think about before approving.
|
👍 from me but I can't do formal approval! |
williamjameswillis
changed the title
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple very minor questions.
gateway-api/tests/conftest.py
Outdated
|
|
||
| # Load environment variables from .env file in the workspace root | ||
| # find_dotenv searches upward from current directory for .env file | ||
| load_dotenv(find_dotenv(usecwd=True)) |
There was a problem hiding this comment.
How does this method behave if no .env file is provided such as within CI for example? Does it simply continue without a .env loaded relying on the values being loaded as environment variables?
There was a problem hiding this comment.
Are the additional arguments to the load_dotenv function here required also as I think the default behaviour is to search upward for a .env file?
There was a problem hiding this comment.
just tested it out to make sure and it returns an empty string so when the tests run they fail with:
ValueError: BASE_URL environment variable is not set.
which is what we want right?
There was a problem hiding this comment.
and yeh good spot i have removed that param
tested it out and works the same without it
|
williamjameswillis
deleted the
feature/GPCAPIM-190_import_common_repo_poetry_dep
branch
3 participants
Description
See https://nhsd-jira.digital.nhs.uk/browse/GPCAPIM-190 for details.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.