Skip to content

Conversation

@Harriethw
Copy link
Contributor

Description

Now that we have removed the sms job 251bf4f we can remove the associated queue and its monitoring.

Jira link

Review notes

Review checklist

  • Check database queries are correctly scoped to current_provider

@Harriethw Harriethw marked this pull request as ready for review December 17, 2025 15:34
@Harriethw Harriethw requested a review from a team as a code owner December 17, 2025 15:34
@Harriethw Harriethw assigned gpeng and MatMoore and unassigned gpeng and MatMoore Dec 17, 2025
@Harriethw Harriethw requested review from MatMoore and gpeng December 17, 2025 15:35
@Harriethw Harriethw force-pushed the dtoss-11768-remove-message-status-queue branch from dba5ba1 to a22c433 Compare December 17, 2025 15:41
@Harriethw Harriethw requested a review from steventux December 17, 2025 15:48
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

The review app at this URL has been deleted:
https://pr-838.manage-breast-screening.non-live.screening.nhs.uk

Copy link
Contributor

@steventux steventux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK. The coupling between queues and collecting metrics has proven to be a bit brittle but I think this covers the issue.
Beginning to wonder if there is any value in preserving the collect metrics job as it only measures queues we are no longer using and given Django has a new background task feature in v 6 we will likely not use Azure Storage Queues in the forseeable.

@Harriethw Harriethw force-pushed the dtoss-11768-remove-message-status-queue branch from a22c433 to cd37c0d Compare January 2, 2026 10:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@Harriethw
Copy link
Contributor Author

Beginning to wonder if there is any value in preserving the collect metrics job as it only measures queues we are no longer using and given Django has a new background task feature in v 6 we will likely not use Azure Storage Queues in the forseeable.

@steventux Oh that's interesting about the background task feature!
Getting rid of Collect Metrics is next on my to-do list but wanted to flag with infra team first in case there was anything they were worried about losing context of

@Harriethw Harriethw merged commit 6765856 into main Jan 2, 2026
16 checks passed
@Harriethw Harriethw deleted the dtoss-11768-remove-message-status-queue branch January 2, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants