Update and delete previous mammogram #849
Conversation
swebberuk
force-pushed
the
DTOSS-11816-edit-delete-mammograms
branch
from
228907e to
5eb448c
Compare
swebberuk
force-pushed
the
DTOSS-11816-edit-delete-mammograms
branch
from
5eb448c to
45b7544
Compare
| {% if delete_link %} | ||
| <p class="nhsuk-u-margin-top-4"> | ||
| <a href="{{ delete_link.href }}" class="{{ delete_link.class }}"> | ||
| {{ delete_link.text }} | ||
| </a> | ||
| </p> | ||
| {% endif %} |
There was a problem hiding this comment.
Should we stick this link inside the button group? @edwardhorsford
https://nhsuk.github.io/nhsuk-frontend/examples/button-group/
There was a problem hiding this comment.
I think / reckon not.
I see button group as mostly being about complimentary choices - continue or perhaps cancel. But delete feels like a distinct action and worthy of being more separated from the continue buttonn.
manage_breast_screening/mammograms/jinja2/mammograms/add_previous_mammogram.jinja
Show resolved
Hide resolved
| {% if mammograms_by_date_added %} | ||
| {% for mammogram in mammograms_by_date_added %} | ||
| <p> | ||
| <a style="float: right" class="nhsuk-link nhsuk-link--no-visited-state" href="{{ mammogram.change_link.href}}"> |
There was a problem hiding this comment.
Is the inline style="float: right" from the prototype @edwardhorsford?
Do we need to set up some styles for this so it works nicely at all sizes?
There was a problem hiding this comment.
It might have been me who introduced it. On the record medical info page I'm expecting it to go away when we switch to the new card component, but not sure about this one.
There was a problem hiding this comment.
This now uses a summary list so I expect this'll probably go away soon?
There was a problem hiding this comment.
I guess we can leave it for now then. Do you know if we've got a ticket for that @edwardhorsford?
There was a problem hiding this comment.
I'm not involved in writing dev tickets, but there's a design ticket in the 'ready for tech review' column so presumably @gpeng will pick up at some point?
Display is now more like this:
There was a problem hiding this comment.
Cool that's good enough for me, just wanted to make sure we don't forget about it
swebberuk
changed the title
swebberuk
force-pushed
the
DTOSS-11816-edit-delete-mammograms
branch
from
45b7544 to
6cb0ab3
Compare
| ) | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
Might be worth moving this fixture into a shared conftest.py under mammograms if there isn't one already. I think we define it in a lot of places and it's not really specific to the tests its used in
Added change links to participant details and medical information
swebberuk
force-pushed
the
DTOSS-11816-edit-delete-mammograms
branch
from
6cb0ab3 to
d161907
Compare
|
4 participants
Added change links to participant details and medical information
Description
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11816
Review notes
Review checklist