Skip to content

Update: [AEA-5931] - Add S3 Notifications Lambda #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bencegadanyi1-nhs merged 48 commits into from
Feb 4, 2026
Merged

Update: [AEA-5931] - Add S3 Notifications Lambda #352

bencegadanyi1-nhs merged 48 commits into from
Feb 4, 2026

Conversation

@kieran-wilkinson-4
Copy link
Contributor

@kieran-wilkinson-4 kieran-wilkinson-4 commented Feb 2, 2026 •
edited
Loading

Summary

Add notification to Slack when files update in S3

Details

  1. Add new Simple Queue Service (SQS)
    • SQS triggers when the S3 bucket updates
    • 60 second buffer for incoming messages
  2. SQS triggers lambdas
    • syncKnowledgeBaseFunction
    • preprocessingFunction
    • notifyS3UploadFunction (new)
  3. New lambda (notifyS3UploadFunction)
    • Collects any files changed over 60 seconds
    • Sends a message to all private channels it is installed in
  4. Moved syncKnowledgeBaseFunction to handle SQS events
    • S3 events are provided as a "message" inside SQS events

kieran-wilkinson-4 and others added 30 commits January 19, 2026 13:08
@kieran-wilkinson-4
feat: Add StorageNotificationQueue
7e7bd4c
@kieran-wilkinson-4
Feat: Reinitialise Branch
972e81f
@kieran-wilkinson-4
Merge branch 'main' into AEA-5931-Add-S3-Notifications
6b986aa
@kieran-wilkinson-4
feat: Update bucket reference
0fb4066
@kieran-wilkinson-4
feat: Update makefile and gitignore
e40d8a9
@kieran-wilkinson-4
feat: Update poetry.lock
c641907
@kieran-wilkinson-4
feat: Improve queue naming
f2543fd
@kieran-wilkinson-4
feat: Move all notifications to a queue
b8ba990
@kieran-wilkinson-4
feat: Move all notifications to a queue
275cab4
@kieran-wilkinson-4
feat: Longer visibility timeout
00fe4c4
@kieran-wilkinson-4
feat: Dont use SSM
3836e56
@kieran-wilkinson-4
feat: Dont use SSM
b37478a
@kieran-wilkinson-4
feat: revert remove policies
1777cee
@kieran-wilkinson-4
feat: modify suppressions
1c48bfd
@bencegadanyi1-nhs
trigger build
7920259
@bencegadanyi1-nhs
Merge branch 'main' into AEA-5931-Add-S3-Notifications
a9887c6
@bencegadanyi1-nhs
trigger build
ef322a5
@kieran-wilkinson-4
feat: Use Slackbot client instead of requests
25755fe
@kieran-wilkinson-4
feat: Use Slackbot client instead of requests
e8c418c
@kieran-wilkinson-4
feat: Use Slackbot client instead of requests
c5da448
@kieran-wilkinson-4
feat: Use Slackbot client instead of requests
21392ac
@kieran-wilkinson-4
feat: Pass client not token
74c9a79
@kieran-wilkinson-4
feat: Pass client not token
0485f22
@kieran-wilkinson-4
chore: tidy up
812b045
@kieran-wilkinson-4
Merge branch 'main' into AEA-5931-Add-S3-Notications-Merge
e944f94
@kieran-wilkinson-4
chore: merge main
7383ae4
@kieran-wilkinson-4
Aea 5931 add s3 notications merge (#351)
571739d 
Safely merge main into 5931
@kieran-wilkinson-4
Merge branch 'AEA-5931-Add-S3-Notications-Merge' into AEA-5931-Add-S3…
173e464 
…-Notifications
@kieran-wilkinson-4
chore: merge main
14cb4b5
@kieran-wilkinson-4
chore: rename simple queue service
098daf9
bencegadanyi1-nhs
bencegadanyi1-nhs previously approved these changes Feb 4, 2026
View reviewed changes
packages/cdk/resources/RuntimePolicies.ts Outdated
resources: [
props.knowledgeBaseArn,
`arn:aws:ssm:${props.region}:${props.account}:parameter${props.slackBotTokenParameterName}`,
`arn:aws:ssm:${props.region}:${props.account}:parameter${props.slackSigningSecretParameterName}`
Copy link
Contributor

@bencegadanyi1-nhs bencegadanyi1-nhs Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking) these two ARNs are already declared in this file, could make them reusable?

packages/notifyS3UploadFunction/app/handler.py Outdated
bucket_name = s3_record["s3"].get("bucket", {}).get("name", None)

if bucket_name is None or "-pr-" in bucket_name:
# Ignore PR buckets
Copy link
Contributor

@bencegadanyi1-nhs bencegadanyi1-nhs Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: (non-blocking) this comment is a left over, isn't needed anymore

packages/notifyS3UploadFunction/app/handler.py Outdated

# Skip if no bucket name (e.g., PR buckets)
# PR Lambdas will post to DEV channels
if bucket_name is None:
Copy link
Contributor

@bencegadanyi1-nhs bencegadanyi1-nhs Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): given the PR noise point you raised, what do you think about gating this behind an env var on the lambda?

default it off for PR stacks to avoid spam, but easy to flip on ad-hoc when we actually want to debug notifications in a PR env

feels like a decent middle ground between DX and not annoying everyone

p.s.: sorry - I know I made you remove the -pr- check earlier today 😅

@bencegadanyi1-nhs bencegadanyi1-nhs enabled auto-merge (squash) February 4, 2026 15:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bencegadanyi1-nhs bencegadanyi1-nhs merged commit 1af73c2 into main Feb 4, 2026
14 checks passed
@bencegadanyi1-nhs bencegadanyi1-nhs deleted the AEA-5931-Add-S3-Notifications branch February 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencegadanyi1-nhs bencegadanyi1-nhs bencegadanyi1-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kieran-wilkinson-4 @bencegadanyi1-nhs