Skip to content

Conversation

@JamesW1-NHS
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS commented Jan 6, 2026

Summary

  • Routine Change

This has resolved itself into a bug fix and a pair of unit tests.

Bug fix in delta_backend - failure reports were being written to SQS twice.

Unit tests added in delta_backend and recordforwarder - to check that exceptions are raised (or not) and logged when there is an unexpected error. The source code itself has not been changed in this respect.

Note to testers: Functionality change in delta_backend only. No change to API or to other lambdas.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-842

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox January 7, 2026 12:25 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS merged commit c4c1649 into master Jan 7, 2026
17 checks passed
@JamesW1-NHS JamesW1-NHS deleted the VED-842-exception-handlers branch January 7, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants