-
Notifications
You must be signed in to change notification settings - Fork 3
VED-842: Exception Handlers #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…munisation-fhir-api into VED-843-refactor-validator
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-842 |
dlzhry2nhs
reviewed
Jan 6, 2026
dlzhry2nhs
approved these changes
Jan 7, 2026
edhall-nhs
approved these changes
Jan 7, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
This has resolved itself into a bug fix and a pair of unit tests.
Bug fix in delta_backend - failure reports were being written to SQS twice.
Unit tests added in delta_backend and recordforwarder - to check that exceptions are raised (or not) and logged when there is an unexpected error. The source code itself has not been changed in this respect.
Note to testers: Functionality change in delta_backend only. No change to API or to other lambdas.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.