-
Notifications
You must be signed in to change notification settings - Fork 3
VED-881: refactor constants for batch lambdas #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VED-881: refactor constants for batch lambdas #1096
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-881 |
|
Sonar code coverage for the new batch_constants file is causing it to fail the quality gate. We don't need any tests for this because it's just a file of constants so we'll see if we can approve and merge as is and if not then I'll put a coverage exclusion in the sonar properties file. |
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, it doesn't allow overriding the merge with coverage below a certain threshold. Might need to put an ignore on the file for now and then we can remove later.
|



Summary
Consolidate and refactor constants shared across batch lambdas.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.