Skip to content

Conversation

@edhall-nhs
Copy link
Contributor

Summary

  • Routine Change

Consolidate and refactor constants shared across batch lambdas.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-881

@edhall-nhs
Copy link
Contributor Author

Sonar code coverage for the new batch_constants file is causing it to fail the quality gate. We don't need any tests for this because it's just a file of constants so we'll see if we can approve and merge as is and if not then I'll put a coverage exclusion in the sonar properties file.

dlzhry2nhs
dlzhry2nhs previously approved these changes Jan 7, 2026
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, it doesn't allow overriding the merge with coverage below a certain threshold. Might need to put an ignore on the file for now and then we can remove later.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@edhall-nhs edhall-nhs merged commit b1f9fc3 into master Jan 8, 2026
17 checks passed
@edhall-nhs edhall-nhs deleted the feature/VED-881-refactor-constants-for-batch-lambdas branch January 8, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants