-
Notifications
You must be signed in to change notification settings - Fork 3
VED-980 Increased given name length constraint #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VED-980 Increased given name length constraint #1102
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-980 |
edhall-nhs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only a suggestion for a slight tweak to a comment
|



Summary
Basic change to relax the given name validation. Check ticket for details - essentially boils down to the fact that batch can only provide name as a single string rather than an array. And also the trust model for our users and the fact that we are not the source of truth for demographic data.
The new proposed limit is still reasonable enough in limiting clearly incorrect payloads.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.