Skip to content

Conversation

@dlzhry2nhs
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs commented Jan 8, 2026

Summary

  • Routine Change

Basic change to relax the given name validation. Check ticket for details - essentially boils down to the fact that batch can only provide name as a single string rather than an array. And also the trust model for our users and the fact that we are not the source of truth for demographic data.

The new proposed limit is still reasonable enough in limiting clearly incorrect payloads.

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-980

edhall-nhs
edhall-nhs previously approved these changes Jan 9, 2026
Copy link
Contributor

@edhall-nhs edhall-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a suggestion for a slight tweak to a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 9, 2026 12:00 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 9, 2026 12:02 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs enabled auto-merge (squash) January 9, 2026 12:02
@dlzhry2nhs dlzhry2nhs merged commit da273a6 into master Jan 9, 2026
17 checks passed
@dlzhry2nhs dlzhry2nhs deleted the feature/VED-980-increase-given-name-max-length branch January 9, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants