Skip to content

PPHA-369: Ensure infra key_vault_secrets_officers is a set #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Themitchell merged 7 commits into from
Oct 14, 2025
Merged

PPHA-369: Ensure infra key_vault_secrets_officers is a set #94

Themitchell merged 7 commits into from
Oct 14, 2025

Conversation

@Themitchell
Copy link
Contributor

@Themitchell Themitchell commented Oct 14, 2025 •
edited by patrickmoore-nc
Loading

What is the change?

  • Parameterise a list of Entra ID group names (per env) to grant the Key Vault Secrets Officer RBAC role.
  • Parameterise the GitHub Actions Managed Identity (per env) so that it also has Key Vault Secrets Officer RBAC role.
  • Alphabetical sort of variables.tf files.

Why are we making this change?

Terrafrom for_each requires a list or set

@Themitchell Themitchell force-pushed the PPHA-369-fix-tuple-to-list-for-key-vault-secrets-officers branch from 4bf34e2 to aad5563 Compare October 14, 2025 11:16
@Themitchell Themitchell changed the title PPHA-369: Ensure infra key_vault_secrets_officers is list PPHA-369: Ensure infra key_vault_secrets_officers is a set Oct 14, 2025
@Themitchell Themitchell merged commit ae5619d into main Oct 14, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Themitchell @patrickmoore-nc