CCM-11889: migrate updated created fields #786
Conversation
|
|
||
| return ( | ||
| <ErrorSummary ref={errorSummaryRef}> | ||
| <ErrorSummary ref={errorSummaryRef} tabIndex={-1}> |
| <div | ||
| class="nhsuk-grid-row nhsuk-grid-column-two-thirds" | ||
| > | ||
| <div |
There was a problem hiding this comment.
this test is for the validation being triggered so I'm not convinced the error summary should be removed from the snapshot?
| <div | ||
| class="nhsuk-grid-row nhsuk-grid-column-two-thirds" | ||
| > | ||
| <div |
| expect(scrollIntoViewMock).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| test('Renders NhsNotifyErrorSummary correctly with empty error state', async () => { |
There was a problem hiding this comment.
I think based on your changes, might also be worth adding tests for errorState object having formError/fieldError keys but with falsy values, since component also won't render in those scenarios either now?
| } from '@aws-sdk/client-cognito-identity-provider'; | ||
| import { logger } from '@/src/utils/logger'; | ||
|
|
||
| export const INTERNAL_ID_ATTRIBUTE = 'custom:nhs_notify_user_id'; |
There was a problem hiding this comment.
the ticket mentions username but I'm guessing this is what we're using instead?
| @@ -1 +0,0 @@ | |||
| *.json | |||
There was a problem hiding this comment.
should we have something similar in the new dir?
| if (error instanceof ConditionalCheckFailedException) { | ||
| return 'lock-failure'; | ||
| } | ||
| logger.error( |
There was a problem hiding this comment.
do you not want one of these error logs before your lock-failure return?
| // act | ||
| let caughtError; | ||
| try { | ||
| await discoverUserPoolId('nonexistent'); |
There was a problem hiding this comment.
Not something to change but an FYI you canw write this as
await expect(discoverUserPoolId('nonexistent')).rejects.toThrowError('User pool nhs-notify-nonexistent-app not found')
3 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.