Draft
Conversation
Collaborator
|
Type of change is not selected in the description of this PR. |
lyashevska
reviewed
Aug 28, 2024
| * Make contributing guidelines optional [#465](https://github.com/NLeSC/python-template/pull/465) | ||
| * Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541) | ||
| * Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530) | ||
| * CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| * CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | |
| * CHANGELOG.md is now optional [#462](https://github.com/NLeSC/python-template/issues/462) |
lyashevska
reviewed
Aug 28, 2024
| * Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541) | ||
| * Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530) | ||
| * CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | ||
| * pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| * pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) | |
| * pre-commit script is optional [#457](https://github.com/NLeSC/python-template/issues/457) |
lyashevska
reviewed
Aug 28, 2024
| validator: >- | ||
| {% if not (package_name | regex_search('^[a-z][a-z0-9\_]+$')) %} | ||
| {% if not (package_name | regex_search('^[A-Za-z][A-Za-z0-9\_]+$')) %} | ||
| Package name must start with a letter, followed one or more letters, digits or underscores all lowercase |
Collaborator
There was a problem hiding this comment.
Suggested change
| Package name must start with a letter, followed one or more letters, digits or underscores all lowercase | |
| Package name must start with a letter, followed one or more letters, digits or underscores |
lyashevska
approved these changes
Aug 28, 2024
Collaborator
lyashevska
left a comment
There was a problem hiding this comment.
thanks @fdiblen See a couple of comments. After that good to go.
Member
Author
|
blocked by #621 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
List of related issues or pull requests**
Refs:
Describe the changes made in this pull request
Package names containing uppercase are allowed.
Instructions to review the pull request
Install the requirements
Create a new package using the template
Create a local git repo to push to GitHub to trigger CI actions