-
Notifications
You must be signed in to change notification settings - Fork 205
Add workflow results #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add workflow results #1275
Conversation
…dd-workflow-results Signed-off-by: Praateek <praateekm@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
Signed-off-by: Praateek <praateekm@gmail.com>
|
/ok to test af0787c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (6)
-
nemo_curator/stages/deduplication/exact/workflow.py, line 257 (link)logic:
id_generator_pathundefined whenself.assign_idisFalse -
nemo_curator/stages/deduplication/fuzzy/workflow.py, line 373 (link)logic:
id_generator_pathundefined when no duplicates found (len(valid_lsh_tasks) == 0) -
tests/stages/text/deduplication/test_removal_workflow.py, line 192 (link)logic: Metadata key mismatch - removal workflow sets
num_duplicates_removed, notnum_duplicates -
tests/stages/text/deduplication/test_removal_workflow.py, line 193 (link)logic:
num_output_tasksnever set in removal workflow metadata -
tests/stages/text/deduplication/test_removal_workflow.py, line 210 (link)logic: Metadata key mismatch - removal workflow sets
num_duplicates_removed, notnum_duplicates -
tests/stages/text/deduplication/test_removal_workflow.py, line 282-283 (link)logic: Metadata key mismatches - removal workflow sets
num_duplicates_removed, notnum_duplicates, and never setsnum_output_tasks
13 files reviewed, 6 comments
Description
This pull request refactors the workflow interfaces for the deduplication pipelines (exact, fuzzy, and semantic) to standardize their outputs and improve usability.
Core API and Interface Refactoring
WorkflowRunResultdataclass innemo_curator/pipeline/workflow.pyto encapsulate workflow outputs, pipeline task mappings, and metadata. Also added an abstractWorkflowBaseclass to standardize workflow interfaces.ExactDeduplicationWorkflow,FuzzyDeduplicationWorkflow,SemanticDeduplicationWorkflow) to inherit fromWorkflowBaseand to return aWorkflowRunResultfrom theirrunmethods, instead of returningNoneor a dictionary.Workflow Output and Metadata Improvements
runmethods of all workflows to collect and record detailed timing and result metadata (such as per-stage execution times and duplicate counts) into theWorkflowRunResultobject.Usage
# Add snippet demonstrating usageChecklist