-
Notifications
You must be signed in to change notification settings - Fork 242
[5676209] Fix duplicated calib data #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5676209] Fix duplicated calib data #794
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe PR adds a new changelog entry for version 0.42 documenting a calibration data generation bug fix in the ONNX workflow. A corresponding bug fix is implemented in the calibration utilities module to prevent shared dictionary state mutations across iterations by using a list comprehension instead of reusing a single dictionary instance. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
=======================================
Coverage 74.19% 74.19%
=======================================
Files 192 192
Lines 19238 19238
=======================================
Hits 14273 14273
Misses 4965 4965 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: gcunhase <4861122+gcunhase@users.noreply.github.com>
Signed-off-by: gcunhase <4861122+gcunhase@users.noreply.github.com>
b153509 to
197d581
Compare
What does this PR do?
Type of change: Bug fix
Overview: This PR fixes an issue with calibration data with multiple samples. Previously, calibration data with multiple samples was generating a data loader with the same sample copied X times instead of generating data with X different samples.
Usage
Testing
Use calibration data from 5676209 and observe the output of
calibration_data_readerinquantize.py:Each calibration sample in the list should be different.
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.