Skip to content

pinning docker image base#385

Open
tbartley94 wants to merge 1 commit intoNVIDIA:mainfrom
tbartley94:docker_hot_fix
Open

pinning docker image base#385
tbartley94 wants to merge 1 commit intoNVIDIA:mainfrom
tbartley94:docker_hot_fix

Conversation

@tbartley94
Copy link
Member

What does this PR do ?

  • Pins base docker image to avoid header issues on build (they updated the docker image which messes up some pathing).

Before your PR is "Ready for review"

Pre checks:

  • [ y] Have you signed your commits? Use git commit -s to sign.
  • [ y] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [y ] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [ y] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [ y] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [ y] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [y ] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [ y] Remove import guards (try import: ... except: ...) if not already done.
  • [ y] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [ y] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • [y ] Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

Signed-off-by: tbartley94 <tbartley@nvidia.com>
@tbartley94 tbartley94 requested a review from mgrafu February 3, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant