Skip to content

NeoUI - Refactor colors theme, general NeoUI QoL#1653

Merged
nullsystem merged 2 commits intoNeotokyoRebuild:masterfrom
nullsystem:GH-1155_NeoUIThemeRefactor
Feb 14, 2026
Merged

NeoUI - Refactor colors theme, general NeoUI QoL#1653
nullsystem merged 2 commits intoNeotokyoRebuild:masterfrom
nullsystem:GH-1155_NeoUIThemeRefactor

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Feb 7, 2026

Description

Aim to make theming not fixed and able to be defined outside of NeoUI. Should be more flexible to theme and more usable as an eventual standalone library. Changed slider background bar rendering looks. Also changed theme style, now have borders for hot items.

  • EXTRAS:
    • Fixed HUD tab F1-F3 text color on final tab
    • Added flags and size control to NeoUI::Tabs
    • Change IFF markers to use NeoUI::Tabs
    • Fix password and blacklist not auto-selecting text box which causes anonyance for players, the text box for those are now force-active, the other buttons/ringbox/keybinds still works fine even with textbox force-active
    • Fix main menu having fonts too small and column too small on Linux, equal-ish the sizing with Windows (just did 1.7x of Windows)
    • Fix ESC not utilize for exit in main menu
    • Fix overlapping hot widgets/check in view
    • Scrolling via mouse drag is now no longer smooth scroll so we don't need to deal with partially shown widgets
    • Fix dislodge x-axis after per-row change (server filter section)
    • Scrollbar now inside the section rather than outside
  • FUTURE TODO:
    • Change dPanel setting to per every NeoUI::BeginSection parameter rather than loose dPanel settings (plan to do this but too much changes/out of scope for this PR)
    • Scrollbar position restore
    • Animated hot border? Lerp smoothing from one widget to the next and rendered at EndContext

Toolchain

  • Linux GCC Distro Native - gcc version 15.2.1 20260103 - Arch Linux

Linked Issues

@nullsystem nullsystem requested a review from a team February 7, 2026 18:04
@nullsystem nullsystem force-pushed the GH-1155_NeoUIThemeRefactor branch 2 times, most recently from e130603 to 947a3e9 Compare February 7, 2026 18:26
Agiel
Agiel previously approved these changes Feb 12, 2026
@Rainyan Rainyan requested a review from a team February 12, 2026 21:59
@DESTROYGIRL
Copy link
Contributor

Unless I've done something wrong the linux only changes in ClientScheme.res might not be working correctly

Image

@DESTROYGIRL
Copy link
Contributor

That aside, the additions looked good but there are some things I would tweak:
Text on selected tabs is too thin / harder to read imo. Try raising the thickness a tiny bit perhaps, (i have a 1080p monitor)
image

Might be personal preference but I don't feel like the border around whatever the cursor is hovering over needs to be so thick. I'd try halving it, but feel free to ignore
image

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use [!$LINUX] instead of [$!LINUX] it seems

@Masterkatze
Copy link
Contributor

A bit of bikeshedding opinion, but:

1.1 I think UI element hover gives an impression of some debug feature or a placeholder effect,
1.2 And also the column header that is currently used for sorting has overlining, which is kinda strange choice, especially when placed under the tabs - it may look like it's related more to the tab rather than column header.
1
Maybe we can use the top/bottom arrow on the right side of a column header to indicate that it's currently sorted (and the sorting order)? Then we can get rid of overlining and only use the underlining for the selected UI element.

  1. I know it's not that related to this PR, but the NeoUI::Divider line color could be more white? It's hard to notice and the settings look cluttered at the first glance:
3

But overall, it looks fine and works without any issues.

Aim to make theming not fixed and able to be defined outside of NeoUI.
Should be more flexible to theme and more usable as an eventual
standalone library. Changed slider background bar rendering looks.
Also changed theme style, now have borders for hot items.

* EXTRAS:
  * Fixed HUD tab F1-F3 text color on final tab
  * Added flags and size control to NeoUI::Tabs
  * Change IFF markers to use NeoUI::Tabs
  * Fix password and blacklist not auto-selecting text box which
    causes anonyance for players, the text box for those are now
    force-active, the other buttons/ringbox/keybinds still works
    fine even with textbox force-active
  * Fix main menu having fonts too big/column too small on Linux,
    equal-ish the sizing with Windows
  * Fix ESC not utilize for exit in main menu
  * Fix overlapping hot widgets/check in view
  * Scrolling via mouse drag is now no longer smooth scroll so we
    don't need to deal with partially shown widgets
  * Fix dislodge x-axis after per-row change (server filter section)
  * Scrollbar now inside the section rather than outside
* FUTURE TODO:
  * Change dPanel setting to per every NeoUI::BeginSection parameter
    rather than loose dPanel settings (plan to do this but too much
    changes/out of scope for this PR)
  * Scrollbar position restore
  * Animated hot border? Lerp smoothing from one widget to the next
    and rendered at EndContext

* fixes NeotokyoRebuild#1155
@DESTROYGIRL
Copy link
Contributor

I know it's not that related to this PR, but the NeoUI::Divider line color could be more white? It's hard to notice and the settings look cluttered at the first glance:

People have suggested making the background of the menus less transparent so it's more coherent with both light and dark backgrounds

@nullsystem
Copy link
Collaborator Author

nullsystem commented Feb 14, 2026

Changes: 3b1d781

@Masterkatze

1.1 I think UI element hover gives an impression of some debug feature or a placeholder effect,

I did the border hover that way mainly for visibility, before it was hard to tell which widget you're hovering over especially in-game against dark areas.

1.2 ... column header ...

I'll address this in a separate PR after this, working on doing NeoUI table headers

2 ... diviers...

I just made them basically white-ish now

@DESTROYGIRL

You need to use [!$LINUX] instead of [$!LINUX] it seems

Fixed the conditional to !$LINUX

... border ...

They're a little thinner now

Text on selected tabs is too thin / harder to read imo

I can't set font weight on Linux, I'm leaving this out for now.

@nullsystem nullsystem added New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. labels Feb 14, 2026
Copy link
Contributor

@Agiel Agiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I could comment more on the actual design, but I figured that'd come later.

@nullsystem nullsystem merged commit e6992b6 into NeotokyoRebuild:master Feb 14, 2026
7 checks passed
@DESTROYGIRL DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. UI/HUD Relates to the HUD, NeoUI, menus, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeoUI Theming refactoring (coloring) Menus scale weirdly on deck

4 participants