Fix neo_restart_this resetting game mode to CTG#1671
Open
Rainyan wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Open
Fix neo_restart_this resetting game mode to CTG#1671Rainyan wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Rainyan wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop unconditionally calling
GatherGameTypeVotesfromCNEORules::RestartGame, because it was determining the game mode based on the players' "neo_vote_game_mode" userinfo cvar values, but this is inappropriate when the correspondingsv_neo_gamemode_enforcementmode is not set.The mechanism itself also seems a bit obscure if the players are required to manually adjust their "neo_vote_game_mode" cvar values by console, but that stuff is out of scope for this PR.
Toolchain
Linked Issues