Make it possible to fire the supa immediately after loading a shell#1681
Merged
Agiel merged 1 commit intoNeotokyoRebuild:masterfrom Feb 14, 2026
Merged
Make it possible to fire the supa immediately after loading a shell#1681Agiel merged 1 commit intoNeotokyoRebuild:masterfrom
Agiel merged 1 commit intoNeotokyoRebuild:masterfrom
Conversation
Agiel
added
the
Tournament Priority
Rainyan
approved these changes
Feb 14, 2026
sunzenshen
approved these changes
Feb 14, 2026
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
LGTM:
supa-cancel-animation-load-followthrough.mp4
Also here is some footage of the before behavior, checking that I understand how it feels when the animation cannot be cancelled on master branch:
supa-before-cannot-animation-load-followthrough.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I didn't actually time this to make sure it's parity but it feels a lot closer. Basically, I only bump nextAttack when starting the reload and not for all the sequences after. A new member m_flNextReload was added to handle the delay between each shell because it was using nextAttack before.
I left the attack delay code commented out in case we want to revisit it later.
Toolchain
Linked Issues